netdev - Re: [PATCH net-next 0/2] devlink: Add board_serial_number field to info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200620120949.GA2748@nanopsycho>
Date:   Sat, 20 Jun 2020 14:09:49 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vasundhara Volam <vasundhara-v.volam@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        michael.chan@...adcom.com, kuba@...nel.org, jiri@...lanox.com,
        jacob.e.keller@...el.com
Subject: Re: [PATCH net-next 0/2] devlink: Add board_serial_number field to
 info_get cb.

Sat, Jun 20, 2020 at 10:15:45AM CEST, vasundhara-v.volam@...adcom.com wrote:
>This patchset adds support for board_serial_number to devlink info_get
>cb and also use it in bnxt_en driver.
>
>Sample output:
>
>$ devlink dev info pci/0000:af:00.1
>pci/0000:af:00.1:
>  driver bnxt_en
>  serial_number 00-10-18-FF-FE-AD-1A-00
>  board_serial_number 433551F+172300000
>  versions:
>      fixed:
>        board.id 7339763 Rev 0.

We have board.id already here. I understand that the serial number does
not belong under the same nest, as it is not a "version".

However, could you at least maintain the format:
board.serial_number
?


>        asic.id 16D7
>        asic.rev 1
>      running:
>        fw 216.1.216.0
>        fw.psid 0.0.0
>        fw.mgmt 216.1.192.0
>        fw.mgmt.api 1.10.1
>        fw.ncsi 0.0.0.0
>        fw.roce 216.1.16.0
>
>Vasundhara Volam (2):
>  devlink: Add support for board_serial_number to info_get cb.
>  bnxt_en: Add board_serial_number field to info_get cb
>
> Documentation/networking/devlink/devlink-info.rst | 12 +++++-------
> drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c |  7 +++++++
> include/net/devlink.h                             |  2 ++
> include/uapi/linux/devlink.h                      |  2 ++
> net/core/devlink.c                                |  8 ++++++++
> 5 files changed, 24 insertions(+), 7 deletions(-)
>
>-- 
>1.8.3.1
>