lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20200620132547.GB6911@plvision.eu> Date: Sat, 20 Jun 2020 16:25:47 +0300 From: Vadym Kochan <vadym.kochan@...ision.eu> To: Jiri Pirko <jiri@...nulli.us> Cc: Ido Schimmel <idosch@...sch.org>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...lanox.com>, Ido Schimmel <idosch@...lanox.com>, Andrew Lunn <andrew@...n.ch>, Oleksandr Mazur <oleksandr.mazur@...ision.eu>, Serhiy Boiko <serhiy.boiko@...ision.eu>, Serhiy Pshyk <serhiy.pshyk@...ision.eu>, Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>, Taras Chornyi <taras.chornyi@...ision.eu>, Andrii Savka <andrii.savka@...ision.eu>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Mickey Rachamim <mickeyr@...vell.com> Subject: Re: [net-next 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x) Hi Jiri, Ido, On Mon, Jun 01, 2020 at 08:24:17AM +0200, Jiri Pirko wrote: > Sat, May 30, 2020 at 05:54:29PM CEST, idosch@...sch.org wrote: > >On Sat, May 30, 2020 at 05:52:31PM +0300, Vadym Kochan wrote: > > [...] > > > >> > WARNING: do not add new typedefs > >> > #1064: FILE: drivers/net/ethernet/marvell/prestera/prestera_hw.h:32: > >> > +typedef void (*prestera_event_cb_t) > >> I may be wrong, as I remember Jiri suggested it and looks like > >> it makes sense. I really don't have strong opinion about this. > > > >OK, so I'll let Jiri comment when he is back at work. > > I was not aware of this warning, but for function callbacks, I think it > is very handy to have them as typedef instead of repeating the prototype > over and over. For that, I don't think this warning makes sense. > > [...] As I said I have no strong opinion on this, but Jiri's suggestion makes sense. It looks like typedef check was mostly about 'struct' and native types definition. Regards, Vadym Kochan
Powered by blists - more mailing lists