netdev - Re: [PATCH net] rxrpc: Fix notification call on completion of discarded calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200620.213240.344394880607292689.davem@davemloft.net>
Date:   Sat, 20 Jun 2020 21:32:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dhowells@...hat.com
Cc:     netdev@...r.kernel.org,
        syzbot+d3eccef36ddbd02713e9@...kaller.appspotmail.com,
        linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix notification call on completion of
 discarded calls

From: David Howells <dhowells@...hat.com>
Date: Fri, 19 Jun 2020 23:38:16 +0100

> When preallocated service calls are being discarded, they're passed to
> ->discard_new_call() to have the caller clean up any attached higher-layer
> preallocated pieces before being marked completed.  However, the act of
> marking them completed now invokes the call's notification function - which
> causes a problem because that function might assume that the previously
> freed pieces of memory are still there.
> 
> Fix this by setting a dummy notification function on the socket after
> calling ->discard_new_call().
> 
> This results in the following kasan message when the kafs module is
> removed.
 ...
> Reported-by: syzbot+d3eccef36ddbd02713e9@...kaller.appspotmail.com
> Fixes: 5ac0d62226a0 ("rxrpc: Fix missing notification")
> Signed-off-by: David Howells <dhowells@...hat.com>

Applied, thanks David.