netdev - Re: missing retval check of call_netdevice_notifiers in dev_change_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d71991b-2339-f569-b8d3-620473e3c004@gmail.com>
Date:   Sun, 21 Jun 2020 10:19:21 -0700
From:   David Ahern <dsahern@...il.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Johannes Berg <johannes@...solutions.net>,
        David Miller <davem@...emloft.net>,
        Petr Machata <petrm@...lanox.com>
Cc:     Netdev <netdev@...r.kernel.org>, Ido Schimmel <idosch@...lanox.com>
Subject: Re: missing retval check of call_netdevice_notifiers in
 dev_change_net_namespace

+Ido

On 6/21/20 1:58 AM, Jason A. Donenfeld wrote:
> 
> Finally, it could be the solution is that modules that use the netdev
> notifier never really rely too heavily upon getting notifications, and
> if they need something reliable, then they rearchitect their code to
> not need that. I could imagine this attitude holding sway here
> somehow, but it's also not very appealing from a code writing and
> refactoring perspective.
> 

The notifiers should be reliable and callers should handle the errors
when a notifier vetoes the change. Anything else leaves networking in an
unknown / inconsistent state.