netdev - Re: [PATCH v2 bpf-next 1/8] net: Refactor xdp_convert_buff_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200622114815.GA14425@localhost.localdomain>
Date:   Mon, 22 Jun 2020 13:48:15 +0200
From:   Lorenzo Bianconi <lorenzo@...nel.org>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org, davem@...emloft.net,
        ast@...nel.org, daniel@...earbox.net, toke@...hat.com,
        lorenzo.bianconi@...hat.com, dsahern@...nel.org,
        David Ahern <dahern@...italocean.com>
Subject: Re: [PATCH v2 bpf-next 1/8] net: Refactor xdp_convert_buff_to_frame

> On Sat, 20 Jun 2020 00:57:17 +0200
> Lorenzo Bianconi <lorenzo@...nel.org> wrote:
> 
> > From: David Ahern <dahern@...italocean.com>
> > 

[...]

> >  	if (unlikely((headroom - metasize) < sizeof(*xdp_frame)))
> > -		return NULL;
> > +		return -ENOMEM;
> 
> IMHO I think ENOMEM is reserved for memory allocations failures.
> I think ENOSPC will be more appropriate here (or EOVERFLOW).

ack, I will fix it in v3

Regards,
Lorenzo

> 
> >  
> >  	/* Catch if driver didn't reserve tailroom for skb_shared_info */
> >  	if (unlikely(xdp->data_end > xdp_data_hard_end(xdp))) {
> >  		XDP_WARN("Driver BUG: missing reserved tailroom");
> > -		return NULL;
> > +		return -ENOMEM;
> 
> Same here.
> 
> >  	}
> >  
> > -	/* Store info in top of packet */
> > -	xdp_frame = xdp->data_hard_start;
> > -
> >  	xdp_frame->data = xdp->data;
> >  	xdp_frame->len  = xdp->data_end - xdp->data;
> >  	xdp_frame->headroom = headroom - sizeof(*xdp_frame);
> >  	xdp_frame->metasize = metasize;
> >  	xdp_frame->frame_sz = xdp->frame_sz;
> >  
> > +	return 0;
> > +}
> > +
> > +/* Convert xdp_buff to xdp_frame */
> > +static inline
> > +struct xdp_frame *xdp_convert_buff_to_frame(struct xdp_buff *xdp)
> > +{
> > +	struct xdp_frame *xdp_frame;
> > +
> > +	if (xdp->rxq->mem.type == MEM_TYPE_XSK_BUFF_POOL)
> > +		return xdp_convert_zc_to_xdp_frame(xdp);
> > +
> > +	/* Store info in top of packet */
> > +	xdp_frame = xdp->data_hard_start;
> > +	if (unlikely(xdp_update_frame_from_buff(xdp, xdp_frame) < 0))
> > +		return NULL;
> > +
> >  	/* rxq only valid until napi_schedule ends, convert to xdp_mem_info */
> >  	xdp_frame->mem = xdp->rxq->mem;
> >  
> 
> 
> 
> -- 
> Best regards,
>   Jesper Dangaard Brouer
>   MSc.CS, Principal Kernel Engineer at Red Hat
>   LinkedIn: http://www.linkedin.com/in/brouer
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)