netdev - Re: [PATCH] [net] dcb_doit: remove redundant skb check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200622123533.4fd450b6@kicinski-fedora-PC1C0HJN>
Date:   Mon, 22 Jun 2020 12:35:33 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Gaurav Singh <gaurav1086@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        netdev@...r.kernel.org (open list:NETWORKING [GENERAL]),
        linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH] [net] dcb_doit: remove redundant skb check

On Sun, 21 Jun 2020 12:56:28 -0400 Gaurav Singh wrote:
> Remove the redundant null check for skb.
> 
> Signed-off-by: Gaurav Singh <gaurav1086@...il.com>

Thanks for the patch, it looks correct, but could you describe your
proof / reasoning based on which this change is correct?

Please post non-bug fixes like this with a [net-next] rather than [net]
tag (https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html).

> diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
> index d2a4553bcf39..84dde5a2066e 100644
> --- a/net/dcb/dcbnl.c
> +++ b/net/dcb/dcbnl.c
> @@ -1736,7 +1736,7 @@ static int dcb_doit(struct sk_buff *skb, struct nlmsghdr *nlh,
>  	struct net_device *netdev;
>  	struct dcbmsg *dcb = nlmsg_data(nlh);
>  	struct nlattr *tb[DCB_ATTR_MAX + 1];
> -	u32 portid = skb ? NETLINK_CB(skb).portid : 0;
> +	u32 portid = NETLINK_CB(skb).portid;
>  	int ret = -EINVAL;
>  	struct sk_buff *reply_skb;
>  	struct nlmsghdr *reply_nlh = NULL;