netdev - Re: [PATCH/RFC] dt-bindings: net: renesas,etheravb: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXN1o9iG+CM-S5DaikkD_W7zyYAwRpZbEE39EY8PjWHLw@mail.gmail.com>
Date:   Mon, 22 Jun 2020 22:09:43 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH/RFC] dt-bindings: net: renesas,etheravb: Convert to json-schema

Hi Sergei,

On Mon, Jun 22, 2020 at 10:04 PM Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> On 06/21/2020 11:17 AM, Geert Uytterhoeven wrote:
> > Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding
> > documentation to json-schema.
> >
> > Add missing properties.
> > Update the example to match reality.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
>
>    As I'm only seeing the formatting issues, here's my:
>
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

Thank you!

> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> > @@ -0,0 +1,269 @@
> [...]
> > +maintainers:
> > +  - Sergei Shtylyov <sergei.shtylyov@...il.com>
>
>    Thank you! :-)

You're (very) welcome ;-)

>
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - renesas,etheravb-r8a7742      # RZ/G1H
> > +              - renesas,etheravb-r8a7743      # RZ/G1M
> > +              - renesas,etheravb-r8a7744      # RZ/G1N
> > +              - renesas,etheravb-r8a7745      # RZ/G1E
> > +              - renesas,etheravb-r8a77470     # RZ/G1C
> > +              - renesas,etheravb-r8a7790      # R-Car H2
> > +              - renesas,etheravb-r8a7791      # R-Car M2-W
> > +              - renesas,etheravb-r8a7792      # R-Car V2H
> > +              - renesas,etheravb-r8a7793      # R-Car M2-N
> > +              - renesas,etheravb-r8a7794      # R-Car E2
>
>    Hm, overindented starting with "- items:"?

I believe this is consistent with e.g. commit 9f60a65bc5e6cd88
("dt-bindings: Clean-up schema indentation formatting").

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds