netdev - Re: [PATCH net-next v3 4/7] net: phy: add backplane kr driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200622144655.49ee2fe2@kicinski-fedora-PC1C0HJN>
Date:   Mon, 22 Jun 2020 14:46:55 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florinel Iordache <florinel.iordache@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        f.fainelli@...il.com, hkallweit1@...il.com, linux@...linux.org.uk,
        devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
        robh+dt@...nel.org, mark.rutland@....com, corbet@....net,
        shawnguo@...nel.org, leoyang.li@....com, madalin.bucur@....nxp.com,
        ioana.ciornei@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 4/7] net: phy: add backplane kr driver
 support

On Mon, 22 Jun 2020 16:35:21 +0300 Florinel Iordache wrote:
> Add support for backplane kr generic driver including link training
> (ieee802.3ap/ba) and fixed equalization algorithm
> 
> Signed-off-by: Florinel Iordache <florinel.iordache@....com>

drivers/net/phy/backplane/backplane.c:60:11: warning: symbol 'backplane_common_features_array' was not declared. Should it be static?
drivers/net/phy/backplane/backplane.c:66:11: warning: symbol 'backplane_protocol_features_array' was not declared. Should it be static?
drivers/net/phy/backplane/backplane.c:1204:40: warning: incorrect type in assignment (different address spaces)
drivers/net/phy/backplane/backplane.c:1204:40:    expected void *[assigned] reg_base
drivers/net/phy/backplane/backplane.c:1204:40:    got void [noderef] <asn:2> *reg_base
drivers/net/phy/backplane/backplane.c: In function â€˜bp_kr_state_machineâ€™:
drivers/net/phy/backplane/backplane.c:590:27: warning: variable â€˜bpdevâ€™ set but not used [-Wunused-but-set-variable]
  590 |  struct backplane_device *bpdev;
      |                           ^~~~~
drivers/net/phy/backplane/link_training.c: In function â€˜lt_train_remote_txâ€™:
drivers/net/phy/backplane/link_training.c:557:6: warning: variable â€˜lp_resp_timeâ€™ set but not used [-Wunused-but-set-variable]
  557 |  u64 lp_resp_time;
      |      ^~~~~~~~~~~~
drivers/net/phy/backplane/link_training.c: In function â€˜lt_train_local_txâ€™:
drivers/net/phy/backplane/link_training.c:1143:15: warning: variable â€˜old_ld_statusâ€™ set but not used [-Wunused-but-set-variable]
 1143 |  int request, old_ld_status;
      |               ^~~~~~~~~~~~~