netdev - Re: [PATCH v2 net 0/3] net: ethtool: netdev_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200622.163406.1755086886045118386.davem@davemloft.net>
Date:   Mon, 22 Jun 2020 16:34:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     alobakin@...me
Cc:     kuba@...nel.org, mkubecek@...e.cz, f.fainelli@...il.com,
        andrew@...n.ch, jiri@...lanox.com, antoine.tenart@...tlin.com,
        steffen.klassert@...unet.com, ayal@...lanox.com,
        therbert@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net 0/3] net: ethtool: netdev_features_strings[]
 cleanup

From: Alexander Lobakin <alobakin@...me>
Date: Sun, 21 Jun 2020 09:55:50 +0000

> This little series adds the last forgotten feature string for
> NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such losses
> in future.
> 
> Patches 2-3 seem more like net-next candidates rather than net-fixes,
> but for me it seems a bit more suitable to pull it during "quiet" RC
> windows, so any new related code could start from this base.
> 
> I was thinking about some kind of static assertion to have an early
> prevention mechanism for this, but the existing of 2 intended holes
> (former NO_CSUM and UFO) makes this problematic, at least at first
> sight.
> 
> v2:
>  - fix the "Fixes:" tag in the first patch;
>  - no functional changes.

Please do not mix bug fixes (missing netdev feature strings, etc.) with
cleanups (indentation changes).

Thank you.