netdev - Re: [RFC v9 09/11] vhost/scsi: switch to buf APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200622100146.GC6675@stefanha-x1.localdomain>
Date:   Mon, 22 Jun 2020 11:01:46 +0100
From:   Stefan Hajnoczi <stefanha@...hat.com>
To:     Eugenio Pérez <eperezma@...hat.com>
Cc:     mst@...hat.com, kvm list <kvm@...r.kernel.org>,
        Stefano Garzarella <sgarzare@...hat.com>,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Jason Wang <jasowang@...hat.com>
Subject: Re: [RFC v9 09/11] vhost/scsi: switch to buf APIs

On Fri, Jun 19, 2020 at 08:23:00PM +0200, Eugenio Pérez wrote:
> @@ -1139,9 +1154,9 @@ vhost_scsi_send_tmf_reject(struct vhost_scsi *vs,
>  	iov_iter_init(&iov_iter, READ, &vq->iov[vc->out], vc->in, sizeof(rsp));
>  
>  	ret = copy_to_iter(&rsp, sizeof(rsp), &iov_iter);
> -	if (likely(ret == sizeof(rsp)))
> -		vhost_add_used_and_signal(&vs->dev, vq, vc->head, 0);
> -	else
> +	if (likely(ret == sizeof(rsp))) {
> +		vhost_scsi_signal_noinput(&vs->dev, vq, &vc->buf);
> +	} else
>  		pr_err("Faulted on virtio_scsi_ctrl_tmf_resp\n");
>  }

The curly brackets are not necessary, but the patch still looks fine:

Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)