netdev - Re: [PATCH v3 bpf-next 2/3] selftests/bpf: add variable-length data concatenation pattern test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee6df475-b7d4-b8ed-dc91-560e42d2e7fc@iogearbox.net>
Date:   Tue, 23 Jun 2020 23:15:58 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        john fastabend <john.fastabend@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 2/3] selftests/bpf: add variable-length data
 concatenation pattern test

On 6/23/20 10:52 PM, Andrii Nakryiko wrote:
> On Tue, Jun 23, 2020 at 1:39 PM Daniel Borkmann <daniel@...earbox.net> wrote:
>> On 6/23/20 5:22 AM, Andrii Nakryiko wrote:
>>> Add selftest that validates variable-length data reading and concatentation
>>> with one big shared data array. This is a common pattern in production use for
>>> monitoring and tracing applications, that potentially can read a lot of data,
>>> but overall read much less. Such pattern allows to determine precisely what
>>> amount of data needs to be sent over perfbuf/ringbuf and maximize efficiency.
>>>
>>> Signed-off-by: Andrii Nakryiko <andriin@...com>
>>
>> Currently getting the below errors on these tests. My last clang/llvm git build
>> is on 4676cf444ea2 ("[Clang] Skip adding begin source location for PragmaLoopHint'd
>> loop when[...]"):
> 
> Yeah, you need 02553b91da5d ("bpf: bpf_probe_read_kernel_str() has to
> return amount of data read on success") from bpf tree.

Fair point, it's in net- but not yet in net-next tree, so bpf-next sync needs
to wait.

> I'm eagerly awaiting bpf being merged into bpf-next :)

I'll cherry-pick 02553b91da5d locally for testing and if it passes I'll push
these out.

Thanks,
Daniel