netdev - RE: [net-next 4/9] i40e: detect and log info about pre-recovery mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61CC2BC414934749BD9F5BF3D5D94044987324EF@ORSMSX112.amr.corp.intel.com>
Date:   Tue, 23 Jun 2020 03:13:35 +0000
From:   "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "Kwapulinski, Piotr" <piotr.kwapulinski@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>,
        "Bowers, AndrewX" <andrewx.bowers@...el.com>
Subject: RE: [net-next 4/9] i40e: detect and log info about pre-recovery mode

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Monday, June 22, 2020 16:56
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>
> Cc: davem@...emloft.net; Kwapulinski, Piotr <piotr.kwapulinski@...el.com>;
> netdev@...r.kernel.org; nhorman@...hat.com; sassmann@...hat.com;
> Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Bowers, AndrewX
> <andrewx.bowers@...el.com>
> Subject: Re: [net-next 4/9] i40e: detect and log info about pre-recovery mode
> 
> On Mon, 22 Jun 2020 15:18:12 -0700 Jeff Kirsher wrote:
> > +static inline bool i40e_check_fw_empr(struct i40e_pf *pf) {
> 
> > +}
> 
> > +static inline i40e_status i40e_handle_resets(struct i40e_pf *pf) {
> > +	const i40e_status pfr = i40e_pf_loop_reset(pf);
> 
> > +
> > +	return is_empr ? I40E_ERR_RESET_FAILED : pfr; }
> 
> There is no need to use the inline keyword in C sources. Compiler will inline
> small static functions, anyway.
> 
> Same thing in patch 8.
[Kirsher, Jeffrey T] 

In patch 8, the functions are not so small and simple.  Are you sure the compiler would inline them if we did not explicitly 'inline' them?  I want to make sure before making that change.