netdev - Re: [PATCH iptables] libxtables/xtables.c - compiler warning fixes for NO_SHARED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANP3RGfGE2PnaZUJ0Yz79sUf=zsQ1hjxHWhP8pEvQD+y2BWq5g@mail.gmail.com>
Date:   Tue, 23 Jun 2020 16:11:36 -0700
From:   Maciej Żenczykowski <zenczykowski@...il.com>
To:     Maciej Żenczykowski <maze@...gle.com>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Florian Westphal <fw@...len.de>
Cc:     Linux Network Development Mailing List <netdev@...r.kernel.org>,
        Netfilter Development Mailing List 
        <netfilter-devel@...r.kernel.org>
Subject: Re: [PATCH iptables] libxtables/xtables.c - compiler warning fixes
 for NO_SHARED_LIBS

>  void xtables_fini(void)
>  {
> +#ifndef NO_SHARED_LIBS
>         dlreg_free();
> +#endif
>  }

Note: I also considered just adding an empty 'void dlreg_free(void)
{}' function in the NO_SHARED_LIBS case, but that doesn't seem to be
the prevalent style...