netdev - Re: [PATCH bpf-next 1/3] flow_dissector: Pull BPF program assignment up to bpf-netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZ0_01j4g-APS9HQ-jqKf3=qTerYWCkRmYscWWo2R0xwg@mail.gmail.com>
Date:   Mon, 22 Jun 2020 23:02:49 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        kernel-team@...udflare.com
Subject: Re: [PATCH bpf-next 1/3] flow_dissector: Pull BPF program assignment
 up to bpf-netns

On Mon, Jun 22, 2020 at 9:03 AM Jakub Sitnicki <jakub@...udflare.com> wrote:
>
> Prepare for using bpf_prog_array to store attached programs by moving out
> code that updates the attached program out of flow dissector.
>
> Managing bpf_prog_array is more involved than updating a single bpf_prog
> pointer. This will let us do it all from one place, bpf/net_namespace.c, in
> the subsequent patch.
>
> No functional change intended.
>
> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> ---

LGTM.

Acked-by: Andrii Nakryiko <andriin@...com>

>  include/net/flow_dissector.h |  3 ++-
>  kernel/bpf/net_namespace.c   | 20 ++++++++++++++++++--
>  net/core/flow_dissector.c    | 13 ++-----------
>  3 files changed, 22 insertions(+), 14 deletions(-)
>

[...]