netdev - Re: [PATCH v3 bpf-next 7/9] libbpf: add SEC name for xdp programs attached to CPUMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200624103609.69ccdff9@carbon>
Date:   Wed, 24 Jun 2020 10:36:09 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Lorenzo Bianconi <lorenzo@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        lorenzo.bianconi@...hat.com, David Ahern <dsahern@...nel.org>,
        brouer@...hat.com
Subject: Re: [PATCH v3 bpf-next 7/9] libbpf: add SEC name for xdp programs
 attached to CPUMAP

On Tue, 23 Jun 2020 22:49:02 -0700
Andrii Nakryiko <andrii.nakryiko@...il.com> wrote:

> On Tue, Jun 23, 2020 at 2:40 PM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
> >
> > As for DEVMAP, support SEC("xdp_cpumap*") as a short cut for loading
                                ^^^^^^^^^^^

Maybe update desc to include the "/" ?
  
> > the program with type BPF_PROG_TYPE_XDP and expected attach type
> > BPF_XDP_CPUMAP.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> > ---  
> 
> Thanks!
> 
> Acked-by: Andrii Nakryiko <andriin@...com>

I like this extra "/".

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

If we agree, I hope we can also adjust this for devmap in bpf-tree ?


> >  tools/lib/bpf/libbpf.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> > index 18461deb1b19..16fa3b84ac38 100644
> > --- a/tools/lib/bpf/libbpf.c
> > +++ b/tools/lib/bpf/libbpf.c
> > @@ -6866,6 +6866,8 @@ static const struct bpf_sec_def section_defs[] = {
> >                 .attach_fn = attach_iter),
> >         BPF_EAPROG_SEC("xdp_devmap",            BPF_PROG_TYPE_XDP,
> >                                                 BPF_XDP_DEVMAP),
> > +       BPF_EAPROG_SEC("xdp_cpumap/",           BPF_PROG_TYPE_XDP,
> > +                                               BPF_XDP_CPUMAP),
> >         BPF_PROG_SEC("xdp",                     BPF_PROG_TYPE_XDP),
> >         BPF_PROG_SEC("perf_event",              BPF_PROG_TYPE_PERF_EVENT),
> >         BPF_PROG_SEC("lwt_in",                  BPF_PROG_TYPE_LWT_IN),
> > --

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer