| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <0dc0796a-1559-d5e9-5297-c95281792a06@samsung.com>
Date: Wed, 24 Jun 2020 12:00:59 +0200
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To: Andrzej Pietrasiewicz <andrzej.p@...labora.com>
Cc: linux-pm@...r.kernel.org, linux-acpi@...r.kernel.org,
netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
platform-driver-x86@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-renesas-soc@...r.kernel.org,
linux-rockchip@...ts.infradead.org,
"Rafael J . Wysocki" <rjw@...ysocki.net>,
Len Brown <lenb@...nel.org>,
Vishal Kulkarni <vishal@...lsio.com>,
"David S . Miller" <davem@...emloft.net>,
Jiri Pirko <jiri@...lanox.com>,
Ido Schimmel <idosch@...lanox.com>,
Johannes Berg <johannes.berg@...el.com>,
Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
Luca Coelho <luciano.coelho@...el.com>,
Intel Linux Wireless <linuxwifi@...el.com>,
Kalle Valo <kvalo@...eaurora.org>,
Peter Kaestle <peter@...e.net>,
Darren Hart <dvhart@...radead.org>,
Andy Shevchenko <andy@...radead.org>,
Sebastian Reichel <sre@...nel.org>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Amit Kucheria <amit.kucheria@...durent.com>,
Support Opensource <support.opensource@...semi.com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Niklas Söderlund <niklas.soderlund@...natech.se>,
Heiko Stuebner <heiko@...ech.de>,
Orson Zhai <orsonzhai@...il.com>,
Baolin Wang <baolin.wang7@...il.com>,
Chunyan Zhang <zhang.lyra@...il.com>,
Zhang Rui <rui.zhang@...el.com>,
Allison Randal <allison@...utok.net>,
Enrico Weigelt <info@...ux.net>,
Gayatri Kammela <gayatri.kammela@...el.com>,
Thomas Gleixner <tglx@...utronix.de>, kernel@...labora.com
Subject: Re: [PATCH v4 08/11] thermal: Explicitly enable non-changing
thermal zone devices
On 5/28/20 9:20 PM, Andrzej Pietrasiewicz wrote:
> Some thermal zone devices never change their state, so they should be
> always enabled.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@...labora.com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_thermal.c | 8 ++++++++
> drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 9 ++++++++-
> drivers/platform/x86/intel_mid_thermal.c | 6 ++++++
> drivers/power/supply/power_supply_core.c | 9 +++++++--
> drivers/thermal/armada_thermal.c | 6 ++++++
> drivers/thermal/dove_thermal.c | 6 ++++++
> .../thermal/intel/int340x_thermal/int3400_thermal.c | 5 +++++
> .../intel/int340x_thermal/int340x_thermal_zone.c | 5 +++++
> drivers/thermal/intel/intel_pch_thermal.c | 5 +++++
> drivers/thermal/intel/intel_soc_dts_iosf.c | 3 +++
> drivers/thermal/intel/x86_pkg_temp_thermal.c | 6 ++++++
> drivers/thermal/kirkwood_thermal.c | 7 +++++++
> drivers/thermal/rcar_thermal.c | 9 ++++++++-
> drivers/thermal/spear_thermal.c | 7 +++++++
> drivers/thermal/st/st_thermal.c | 5 +++++
> drivers/thermal/thermal_of.c | 10 +++++++++-
> 16 files changed, 101 insertions(+), 5 deletions(-)
[...]
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index 3c0397a29b8c..8e8c9af7e5f4 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -485,6 +485,10 @@ static int int3400_thermal_probe(struct platform_device *pdev)
> goto free_art_trt;
> }
>
> + result = thermal_zone_device_enable(priv->thermal);
I'm not sure about correctness of this addition.
This driver contains ->set_mode but doesn't call it on initialization
(in v3 it was using THERMAL_DEVICE_DISABLED as .initial_mode parameter).
> + if (result)
> + goto free_tzd;
> +
> priv->rel_misc_dev_res = acpi_thermal_rel_misc_device_add(
> priv->adev->handle);
>
> @@ -518,6 +522,7 @@ static int int3400_thermal_probe(struct platform_device *pdev)
> free_rel_misc:
> if (!priv->rel_misc_dev_res)
> acpi_thermal_rel_misc_device_remove(priv->adev->handle);
> +free_tzd:
> thermal_zone_device_unregister(priv->thermal);
> free_art_trt:
> kfree(priv->trts);
[...]
> diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
> index 43a516a35d64..011fd7f0a01e 100644
> --- a/drivers/thermal/thermal_of.c
> +++ b/drivers/thermal/thermal_of.c
> @@ -1066,7 +1066,7 @@ int __init of_parse_thermal_zones(void)
> for_each_available_child_of_node(np, child) {
> struct thermal_zone_device *zone;
> struct thermal_zone_params *tzp;
> - int i, mask = 0;
> + int i, ret, mask = 0;
> u32 prop;
>
> tz = thermal_of_build_thermal_zone(child);
> @@ -1113,6 +1113,14 @@ int __init of_parse_thermal_zones(void)
> of_thermal_free_zone(tz);
> /* attempting to build remaining zones still */
> }
> + ret = thermal_zone_device_enable(zone);
This doesn't seem correct as it is done too early and
there is already proper thermal_zone_device_enable() call
in thermal_zone_of_sensor_register().
> + if (ret) {
> + thermal_zone_device_unregister(zone);
> + pr_err("Failed to enable thermal zone\n");
> + kfree(tzp);
> + kfree(ops);
> + of_thermal_free_zone(tz);
> + }
> }
> of_node_put(np);
>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Powered by blists - more mailing lists