netdev - Re: [PATCH bpf-next v2] tools: bpftool: fix variable shadowing in emit_obj_refs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01cd9c60-c563-4c7c-ec8a-a9dfbcec3867@iogearbox.net>
Date:   Wed, 24 Jun 2020 16:18:27 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Quentin Monnet <quentin@...valent.com>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v2] tools: bpftool: fix variable shadowing in
 emit_obj_refs_json()

On 6/23/20 11:36 PM, Quentin Monnet wrote:
> Building bpftool yields the following complaint:
> 
>      pids.c: In function 'emit_obj_refs_json':
>      pids.c:175:80: warning: declaration of 'json_wtr' shadows a global declaration [-Wshadow]
>        175 | void emit_obj_refs_json(struct obj_refs_table *table, __u32 id, json_writer_t *json_wtr)
>            |                                                                 ~~~~~~~~~~~~~~~^~~~~~~~
>      In file included from pids.c:11:
>      main.h:141:23: note: shadowed declaration is here
>        141 | extern json_writer_t *json_wtr;
>            |                       ^~~~~~~~
> 
> Let's rename the variable.
> 
> v2:
> - Rename the variable instead of calling the global json_wtr directly.
> 
> Signed-off-by: Quentin Monnet <quentin@...valent.com>

Applied, thanks!