netdev - Re: [PATCH v3 bpf-next 7/9] libbpf: add SEC name for xdp programs attached to CPUMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+tiHo1y12ae4EREtBiU=AKUW7upMV4Pfa8Yc7mrAsqEg@mail.gmail.com>
Date:   Wed, 24 Jun 2020 07:29:48 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        lorenzo.bianconi@...hat.com, David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH v3 bpf-next 7/9] libbpf: add SEC name for xdp programs
 attached to CPUMAP

On Wed, Jun 24, 2020 at 1:36 AM Jesper Dangaard Brouer
<brouer@...hat.com> wrote:
>
> On Tue, 23 Jun 2020 22:49:02 -0700
> Andrii Nakryiko <andrii.nakryiko@...il.com> wrote:
>
> > On Tue, Jun 23, 2020 at 2:40 PM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
> > >
> > > As for DEVMAP, support SEC("xdp_cpumap*") as a short cut for loading
>                                 ^^^^^^^^^^^
>
> Maybe update desc to include the "/" ?

+1

>
> > > the program with type BPF_PROG_TYPE_XDP and expected attach type
> > > BPF_XDP_CPUMAP.
> > >
> > > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> > > ---
> >
> > Thanks!
> >
> > Acked-by: Andrii Nakryiko <andriin@...com>
>
> I like this extra "/".
>
> Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>
>
> If we agree, I hope we can also adjust this for devmap in bpf-tree ?

Yes. Please.
It's not in an official release. There is time to adjust things.