lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 24 Jun 2020 20:03:08 +0300
From:   Anton Danilov <>
To:     Stephen Hemminger <>
Cc:     Linux Kernel Network Developers <>
Subject: Re: [PATCH v2] tc: qdisc: filter qdisc's by parent/handle specification

Hello, Stephen. Thanks for feedback.

I'm stuck in the error description. I can use just
  invarg("mutually exclusive options", *argv)

But from the user's point of view it isn't completely clear. I think it's
better to return a little bit more detailed error message. Something like this:
  if (filter_parent)
      invarg("parent is already specified", *argv);
  else if (filter_handle)
      invarg("handle is already specified", *argv);

Also I have declined the idea about adding the get command. Think the show
command is enough, and usage of the one more alias is unnecessary.

What do you think about this?

Anton Danilov.

Powered by blists - more mailing lists