[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200624173854.xrnsbrjmrft7orus@ast-mbp.dhcp.thefacebook.com>
Date: Wed, 24 Jun 2020 10:38:54 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc: Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
Network Development <netdev@...r.kernel.org>,
Alexei Starovoitov <ast@...com>,
Daniel Borkmann <daniel@...earbox.net>,
Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] libbpf: add debug message for each created
program
On Wed, Jun 24, 2020 at 09:34:52AM -0700, Andrii Nakryiko wrote:
>
> Just yesterday (or two days ago, maybe), having those CO-RE relocation
> logs, which I fought to keep when I added CO-RE relocs initially,
> immediately shown that a person doesn't have bpf_iter compiled in its
> running kernel, despite the claims otherwise.
...
> of the time, but sometimes even these ELF parsing logs are important.
Prints for reloc make sense to me because that's libbpf's job.
Whereas info about elf sections could have been received by asking
that remote person to do objdump or llvm-objdump on the .o
Printing elf data from libbpf is an indication that libbpf itself
is not sure whether it has bugs in elf parsing. If that's the case
still after those years in production it just sad state of libbpf.
There could be an elf parsing bug there, of course, but keeping
all of that verbosity for likely rare bug is just not right.
Powered by blists - more mailing lists