netdev - Re: [PATCH v3 bpf-next 2/3] selftests/bpf: add variable-length data concatenation pattern test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzaZOkgiuhVYbXpVSfDVHZ5CeqoKENsCo1UeY5kWEB6m+g@mail.gmail.com>
Date:   Wed, 24 Jun 2020 11:26:33 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     John Fastabend <john.fastabend@...il.com>,
        Yonghong Song <yhs@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 2/3] selftests/bpf: add variable-length data
 concatenation pattern test

On Wed, Jun 24, 2020 at 11:19 AM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Tue, Jun 23, 2020 at 11:51 PM Andrii Nakryiko
> <andrii.nakryiko@...il.com> wrote:
> >
> > long
> > represent reality, it causes more straightforward code generation, if
> > you don't aritifically down-cast types.
>
> yep. s/int/long/ conversion in bpf_helpers_def.h definitely improves
> generated code.
>
> > But even better is to just fix types of your local variables to match
> > native BPF size.
>
> I've applied int to long conversion for test_get_stack_rawtp.c test for now.
>
> Let's try to keep 100% passing rate for test_progs and test_progs-no_alu32 :)

Yeah, my bad. I was 100% sure that I tested both back when I did the
change, but nothing is 100% in this world, apparently :)

As for test_progs-no_alu32, I'll add them to Travis CI as well (right
now we only run test_progs), that will help. But I'll try to keep
test_progs-no_alu32 in mind when doing tests locally as well.