netdev - Re: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200624.144810.1787595389624931255.davem@davemloft.net>
Date:   Wed, 24 Jun 2020 14:48:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     s.hauer@...gutronix.de
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, thomas.petazzoni@...tlin.com,
        kernel@...gutronix.de, linux@...linux.org.uk
Subject: Re: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non
 serdes modes

From: Sascha Hauer <s.hauer@...gutronix.de>
Date: Wed, 24 Jun 2020 09:00:44 +0200

> In mvneta_config_interface() the RGMII modes are catched by the default
> case which is an error return. The RGMII modes are valid modes for the
> driver, so instead of returning an error add a break statement to return
> successfully.
> 
> This avoids this warning for non comphy SoCs which use RGMII, like
> SolidRun Clearfog:
> 
> WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 mvneta_start_dev+0x220/0x23c
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>

Applied.