netdev - Re: [net-next V2 03/10] net/mlx5: Add a missing macro undefinition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff82fea55817b95e0995e3f2cb6dcce2e2fdbb01.camel@mellanox.com>
Date:   Wed, 24 Jun 2020 02:46:50 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Leon Romanovsky <leonro@...lanox.com>,
        "xianfengting221@....com" <xianfengting221@....com>
Subject: Re: [net-next V2 03/10] net/mlx5: Add a missing macro undefinition

On Tue, 2020-06-23 at 19:18 -0700, Saeed Mahameed wrote:
> From: Hu Haowen <xianfengting221@....com>
> 
> The macro ODP_CAP_SET_MAX is only used in function
> handle_hca_cap_odp()
> in file main.c, so it should be undefined when there are no more uses
> of it.
> 
> Signed-off-by: Hu Haowen <xianfengting221@....com>
> Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> ---

hmm, I just saw that there were some strong opinions against this
patch, and actually i agree with them :), will drop it .. 

>  drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> index 8b658908f0442..be038ed1658b8 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> @@ -489,6 +489,8 @@ static int handle_hca_cap_odp(struct
> mlx5_core_dev *dev, void *set_ctx)
>  	ODP_CAP_SET_MAX(dev, dc_odp_caps.read);
>  	ODP_CAP_SET_MAX(dev, dc_odp_caps.atomic);
>  
> +#undef ODP_CAP_SET_MAX
> +
>  	if (!do_set)
>  		return 0;
>