netdev - Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200623.202403.1704397333023796145.davem@davemloft.net>
Date:   Tue, 23 Jun 2020 20:24:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     likaige@...ngson.cn
Cc:     kuba@...nel.org, benve@...co.com, _govind@....com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        lixuefeng@...ngson.cn, yangtiezhu@...ngson.cn
Subject: Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in
 enic_init_affinity_hint()

From: Kaige Li <likaige@...ngson.cn>
Date: Wed, 24 Jun 2020 10:07:16 +0800

> You are right. Should I do spin_unlock before the enic_open, or remove
> spin_lock in enic_reset?

You need to learn how this driver's locking works and design a correct
adjustment.