netdev - RE: [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: eliminate division in napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Jun 2020 17:03:43 +0000
From:   "Bowers, AndrewX" <andrewx.bowers@...el.com>
To:     "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: eliminate
 division in napi_poll data path

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Magnus Karlsson
> Sent: Tuesday, June 23, 2020 2:44 AM
> To: Karlsson, Magnus <magnus.karlsson@...el.com>; Topel, Bjorn
> <bjorn.topel@...el.com>; intel-wired-lan@...ts.osuosl.org; Kirsher, Jeffrey T
> <jeffrey.t.kirsher@...el.com>; Samudrala, Sridhar
> <sridhar.samudrala@...el.com>
> Cc: maciejromanfijalkowski@...il.com; Fijalkowski, Maciej
> <maciej.fijalkowski@...el.com>; netdev@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: eliminate division in
> napi_poll data path
> 
> Eliminate a division in the napi_poll data path. This division is executed even
> though it is only needed in the rare case when there are not enough
> interrupt lines so they have to be shared between queue pairs. Instead, just
> test for this case and only execute the division if needed. The code has been
> lifted from the ice driver.
> 
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@...el.com>