netdev - RE: [Intel-wired-lan] [PATCH net-next v2 3/3] i40e: move check of full Tx ring to outside of send loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN6PR1101MB2145E97EE9FE44B7BA49F75D8C920@BN6PR1101MB2145.namprd11.prod.outlook.com>
Date:   Thu, 25 Jun 2020 17:04:23 +0000
From:   "Bowers, AndrewX" <andrewx.bowers@...el.com>
To:     "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next v2 3/3] i40e: move check of
 full Tx ring to outside of send loop

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Magnus Karlsson
> Sent: Tuesday, June 23, 2020 2:44 AM
> To: Karlsson, Magnus <magnus.karlsson@...el.com>; Topel, Bjorn
> <bjorn.topel@...el.com>; intel-wired-lan@...ts.osuosl.org; Kirsher, Jeffrey T
> <jeffrey.t.kirsher@...el.com>; Samudrala, Sridhar
> <sridhar.samudrala@...el.com>
> Cc: maciejromanfijalkowski@...il.com; Fijalkowski, Maciej
> <maciej.fijalkowski@...el.com>; netdev@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next v2 3/3] i40e: move check of full Tx
> ring to outside of send loop
> 
> Move the check if the Hw Tx ring is full to outside the send loop. Currently it
> is checked for every single descriptor that we send. Instead, tell the send
> loop to only process a maximum number of packets equal to the number of
> available slots in the Tx ring. This way, we can remove the check inside the
> send loop to and gain some performance.
> 
> Suggested-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 20 +++++---------------
>  1 file changed, 5 insertions(+), 15 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@...el.com>