netdev - Antwort: Re: [PATCH v2] net: bridge: enfore alignment for ethernet address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OFB3DAEE48.90B85F69-ONC1258592.006D0CB5-C1258592.006D205A@avm.de>
Date:   Thu, 25 Jun 2020 21:51:57 +0200
From:   t.martitz@....de
To:     "David Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        nikolay@...ulusnetworks.com, kuba@...nel.org, nbd@....name,
        stable@...r.kernel.org
Subject: Antwort: Re: [PATCH v2] net: bridge: enfore alignment for ethernet address



-----netdev-owner@...r.kernel.org schrieb: -----

>An: t.martitz@....de
>Von: "David Miller" 
>Gesendet von: netdev-owner@...r.kernel.org
>Datum: 25.06.2020 21:38
>Kopie: netdev@...r.kernel.org, roopa@...ulusnetworks.com,
>nikolay@...ulusnetworks.com, kuba@...nel.org, nbd@....name,
>stable@...r.kernel.org
>Betreff: Re: [PATCH v2] net: bridge: enfore alignment for ethernet
>address
>
>From: Thomas Martitz <t.martitz@....de>
>Date: Thu, 25 Jun 2020 14:26:03 +0200
>
>> The eth_addr member is passed to ether_addr functions that require
>> 2-byte alignment, therefore the member must be properly aligned
>> to avoid unaligned accesses.
>> 
>> The problem is in place since the initial merge of multicast to
>unicast:
>> commit 6db6f0eae6052b70885562e1733896647ec1d807 bridge: multicast
>to unicast
>> 
>> Fixes: 6db6f0eae605 ("bridge: multicast to unicast")
>> Cc: Roopa Prabhu <roopa@...ulusnetworks.com>
>> Cc: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
>> Cc: David S. Miller <davem@...emloft.net>
>> Cc: Jakub Kicinski <kuba@...nel.org>
>> Cc: Felix Fietkau <nbd@....name>
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Thomas Martitz <t.martitz@....de>
>
>Applied and queued up for -stable.

Awesome, thank you! I was about to resend the patch with the Nikolay's
Acked-By, but turns out that wasn't necessary.

>
>Please do not explicitly CC: stable for networking changes, I take
>care
>of those by hand.
>

Alright, I'll remeber that. This was my very first submission to the kernel,
everywhere it is suggested to Cc: stable.

Best regards.