netdev - Re: [PATCH ethtool v3 2/6] Add cable test TDR support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200625212927.7hyoa4dxcnviy2x3@lion.mk-sys.cz>
Date:   Thu, 25 Jun 2020 23:29:27 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev <netdev@...r.kernel.org>, Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH ethtool v3 2/6] Add cable test TDR support

On Thu, Jun 25, 2020 at 09:24:42PM +0200, Andrew Lunn wrote:
> Add support for accessing the cable test time domain reflectromatry
> data. Add a new command --cable-test-tdr, and support for dumping the
> data which is returned.
> 
> signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---

Looks good to me, except for the use of global variable breakout that I
commented at patch 1/6.

Michal