netdev - Re: [PATCH v2 2/2] net: macb: free resources on failure path of at91ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200625.160037.879221379667078763.davem@davemloft.net>
Date:   Thu, 25 Jun 2020 16:00:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     claudiu.beznea@...rochip.com
Cc:     nicolas.ferre@...rochip.com, kuba@...nel.org,
        alexandre.belloni@...tlin.com, antoine.tenart@...tlin.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] net: macb: free resources on failure path of
 at91ether_open()

From: Claudiu Beznea <claudiu.beznea@...rochip.com>
Date: Wed, 24 Jun 2020 13:08:18 +0300

> DMA buffers were not freed on failure path of at91ether_open().
> Along with changes for freeing the DMA buffers the enable/disable
> interrupt instructions were moved to at91ether_start()/at91ether_stop()
> functions and the operations on at91ether_stop() were done in
> their reverse order (compared with how is done in at91ether_start()):
> before this patch the operation order on interface open path
> was as follows:
> 1/ alloc DMA buffers
> 2/ enable tx, rx
> 3/ enable interrupts
> and the order on interface close path was as follows:
> 1/ disable tx, rx
> 2/ disable interrupts
> 3/ free dma buffers.
> 
> Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>

Also applied and queued up for -stable.

Please submit a proper header posting "[PATCH 0/N] " in the future
when you submit a patch series.  Thank you.