netdev - Re: [PATCH net] ethtool: fix error handling in linkstate_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200625.161735.822308990824129945.davem@davemloft.net>
Date:   Thu, 25 Jun 2020 16:17:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mkubecek@...e.cz
Cc:     kuba@...nel.org, netdev@...r.kernel.org, o.rempel@...gutronix.de
Subject: Re: [PATCH net] ethtool: fix error handling in
 linkstate_prepare_data()

From: Michal Kubecek <mkubecek@...e.cz>
Date: Thu, 25 Jun 2020 00:09:08 +0200 (CEST)

> When getting SQI or maximum SQI value fails in linkstate_prepare_data(), we
> must not return without calling ethnl_ops_complete(dev) as that could
> result in imbalance between ethtool_ops ->begin() and ->complete() calls.
> 
> Fixes: 806602191592 ("ethtool: provide UAPI for PHY Signal Quality Index (SQI)")
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Applied, thank you.