netdev - Re: [v2,net-next 4/4] net: enetc add tc flower offload flow metering policing action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200624.220457.1703184551117160217.davem@davemloft.net>
Date:   Wed, 24 Jun 2020 22:04:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     po.liu@....com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        idosch@...sch.org, jiri@...nulli.us, vinicius.gomes@...el.com,
        vlad@...lov.dev, claudiu.manoil@....com, vladimir.oltean@....com,
        alexandru.marginean@....com, michael.chan@...adcom.com,
        vishal@...lsio.com, saeedm@...lanox.com, leon@...nel.org,
        jiri@...lanox.com, idosch@...lanox.com,
        alexandre.belloni@...tlin.com, UNGLinuxDriver@...rochip.com,
        kuba@...nel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        simon.horman@...ronome.com, pablo@...filter.org,
        moshe@...lanox.com, m-karicheri2@...com,
        andre.guedes@...ux.intel.com, stephen@...workplumber.org
Subject: Re: [v2,net-next 4/4] net: enetc add tc flower offload flow
 metering policing action

From: Po Liu <po.liu@....com>
Date: Wed, 24 Jun 2020 17:36:31 +0800

> From: Po Liu <Po.Liu@....com>
> 
> Flow metering entries in IEEE 802.1Qci is an optional function for a
> flow filtering module. Flow metering is two rates two buckets and three
> color marker to policing the frames. This patch only enable one rate one
> bucket and in color blind mode. Flow metering instance are as
> specified in the algorithm in MEF 10.3 and in Bandwidth Profile
> Parameters. They are:
> 
> a) Flow meter instance identifier. An integer value identifying the flow
> meter instance. The patch use the police 'index' as thin value.
> b) Committed Information Rate (CIR), in bits per second. This patch use
> the 'rate_bytes_ps' represent this value.
> c) Committed Burst Size (CBS), in octets. This patch use the 'burst'
> represent this value.
> d) Excess Information Rate (EIR), in bits per second.
> e) Excess Burst Size per Bandwidth Profile Flow (EBS), in octets.
> And plus some other parameters. This patch set EIR/EBS default disable
> and color blind mode.
> 
> v1->v2 changes:
> - Use div_u64() as division replace the '/' report:
> 
> Reported-by: kernel test robot <lkp@...el.com>
> All errors (new ones prefixed by >>):
> 
>    ld: drivers/net/ethernet/freescale/enetc/enetc_qos.o: in function `enetc_flowmeter_hw_set':
>>> enetc_qos.c:(.text+0x66): undefined reference to `__udivdi3'
> 
> 
> Signed-off-by: Po Liu <Po.Liu@....com>

Applied.