netdev - Re: [ethtool v2 3/6] json_writer: Import the iproute2 helper code for JSON output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200624223202.6ddc891f@hermes.lan>
Date:   Wed, 24 Jun 2020 22:32:02 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Michal Kubecek <mkubecek@...e.cz>, netdev <netdev@...r.kernel.org>,
        Chris Healy <cphealy@...il.com>
Subject: Re: [ethtool v2 3/6] json_writer: Import the iproute2 helper code
 for JSON output

On Thu, 25 Jun 2020 02:12:41 +0200
Andrew Lunn <andrew@...n.ch> wrote:

> In general, Linux network tools use JSON for machine readable output.
> See for example -json for iproute2 and devlink. In order to support
> JSON output from ethtool, import the iproute2 helper code.
> 
> Maybe some time in the future it would make sense to either have a
> shared library, or to merge ethtool into the iproute2 source
> distribution?
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

LGTM

Acked-by: Stephen Hemminger <stephen@...workplumber.org>

A shared library is hard to version and gets to be a chore.