netdev - Re: [PATCH ipsec-next v2 2/6] xfrm: replay: get rid of duplicated notification code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200625100910.GY26990@breakpoint.cc>
Date:   Thu, 25 Jun 2020 12:09:10 +0200
From:   Florian Westphal <fw@...len.de>
To:     Sabrina Dubroca <sd@...asysnail.net>
Cc:     Florian Westphal <fw@...len.de>, steffen.klassert@...unet.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH ipsec-next v2 2/6] xfrm: replay: get rid of duplicated
 notification code

Sabrina Dubroca <sd@...asysnail.net> wrote:
> >  	case XFRM_REPLAY_MODE_BMP:
> >  		xfrm_replay_notify_bmp(x, event);
> > -		return;
> > +		goto notify;
> >  	case XFRM_REPLAY_MODE_ESN:
> >  		xfrm_replay_notify_esn(x, event);
> > -		return;
> > +		goto notify;
> 
> These two functions have some early returns that skip the
> notification, but now the notification will be sent in all cases:

Right, I will rework this series.

Thanks for pointing this out.