netdev - RE: [net-next v3 12/15] iecm: Add singleq TX/RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW3PR11MB45228441F903267FBEC31EF98F930@MW3PR11MB4522.namprd11.prod.outlook.com>
Date:   Fri, 26 Jun 2020 17:52:52 +0000
From:   "Brady, Alan" <alan.brady@...el.com>
To:     Joe Perches <joe@...ches.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "Michael, Alice" <alice.michael@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Burra, Phani R" <phani.r.burra@...el.com>,
        "Hay, Joshua A" <joshua.a.hay@...el.com>,
        "Chittim, Madhu" <madhu.chittim@...el.com>,
        "Linga, Pavan Kumar" <pavan.kumar.linga@...el.com>,
        "Skidmore, Donald C" <donald.c.skidmore@...el.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
Subject: RE: [net-next v3 12/15] iecm: Add singleq TX/RX

> -----Original Message-----
> From: Joe Perches <joe@...ches.com>
> Sent: Thursday, June 25, 2020 8:12 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; davem@...emloft.net
> Cc: Michael, Alice <alice.michael@...el.com>; netdev@...r.kernel.org;
> nhorman@...hat.com; sassmann@...hat.com; Brady, Alan
> <alan.brady@...el.com>; Burra, Phani R <phani.r.burra@...el.com>; Hay,
> Joshua A <joshua.a.hay@...el.com>; Chittim, Madhu
> <madhu.chittim@...el.com>; Linga, Pavan Kumar
> <pavan.kumar.linga@...el.com>; Skidmore, Donald C
> <donald.c.skidmore@...el.com>; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; Samudrala, Sridhar
> <sridhar.samudrala@...el.com>
> Subject: Re: [net-next v3 12/15] iecm: Add singleq TX/RX
> 
> On Thu, 2020-06-25 at 19:07 -0700, Jeff Kirsher wrote:
> > From: Alice Michael <alice.michael@...el.com>
> >
> > Implement legacy single queue model for TX/RX flows.
> []
> > diff --git a/drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c
> > b/drivers/net/ethernet/intel/iecm/iecm_singleq_txrx.c
> []
> > @@ -145,7 +508,63 @@ static void iecm_rx_singleq_csum(struct iecm_queue
> *rxq, struct sk_buff *skb,
> >  				 struct iecm_singleq_base_rx_desc *rx_desc,
> >  				 u8 ptype)
> >  {
> []
> > +	if (ipv4 && (rx_error & (BIT(IECM_RX_BASE_DESC_ERROR_IPE_S) |
> > +				 BIT(IECM_RX_BASE_DESC_ERROR_EIPE_S))))
> > +		goto checksum_fail;
> > +	else if (ipv6 && (rx_status &
> > +		 (BIT(IECM_RX_BASE_DESC_STATUS_IPV6EXADD_S))))
> > +		goto checksum_fail;
> > +
> > +	/* check for L4 errors and handle packets that were not able to be
> > +	 * checksummed due to arrival speed
> > +	 */
> > +	if (rx_error & BIT(IECM_RX_BASE_DESC_ERROR_L3L4E_S))
> > +		goto checksum_fail;
> []
> > +checksum_fail:
> > +	dev_dbg(rxq->dev, "RX Checksum not available\n");
> 
> If there's an actual checksum arrival speed issue, then likely this dbg output
> should be ratelimited too.
> 

Yeah this is an issue.  I think we want to add a counter here instead of printing anything out anyway.  Will fix.

Alan