netdev - Re: [net-next v3 09/15] iecm: Init and allocate vport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200626120008.43fe087f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 26 Jun 2020 12:00:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     davem@...emloft.net, Alice Michael <alice.michael@...el.com>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        Alan Brady <alan.brady@...el.com>,
        Phani Burra <phani.r.burra@...el.com>,
        Joshua Hay <joshua.a.hay@...el.com>,
        Madhu Chittim <madhu.chittim@...el.com>,
        Pavan Kumar Linga <pavan.kumar.linga@...el.com>,
        Donald Skidmore <donald.c.skidmore@...el.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Sridhar Samudrala <sridhar.samudrala@...el.com>
Subject: Re: [net-next v3 09/15] iecm: Init and allocate vport

On Thu, 25 Jun 2020 19:07:31 -0700 Jeff Kirsher wrote:
> @@ -532,7 +540,12 @@ static void iecm_service_task(struct work_struct *work)
>   */
>  static void iecm_up_complete(struct iecm_vport *vport)
>  {
> -	/* stub */
> +	netif_set_real_num_rx_queues(vport->netdev, vport->num_txq);
> +	netif_set_real_num_tx_queues(vport->netdev, vport->num_rxq);

These can fail.

> +	netif_carrier_on(vport->netdev);
> +	netif_tx_start_all_queues(vport->netdev);
> +
> +	vport->adapter->state = __IECM_UP;
>  }