netdev - Re: [PATCH v2] net: mvneta: speed down the PHY, if WoL used, to save energy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200626.133650.2064799999224373059.davem@davemloft.net>
Date:   Fri, 26 Jun 2020 13:36:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dgcbueu@...il.com
Cc:     netdev@...r.kernel.org, thomas.petazzoni@...tlin.com,
        andrew@...n.ch, rmk+kernel@...linux.org.uk, f.fainelli@...il.com
Subject: Re: [PATCH v2] net: mvneta: speed down the PHY, if WoL used, to
 save energy

From: Daniel González Cabanelas <dgcbueu@...il.com>
Date: Fri, 26 Jun 2020 17:18:19 +0200

> Some PHYs connected to this ethernet hardware support the WoL feature.
> But when WoL is enabled and the machine is powered off, the PHY remains
> waiting for a magic packet at max speed (i.e. 1Gbps), which is a waste of
> energy.
> 
> Slow down the PHY speed before stopping the ethernet if WoL is enabled,
> and save some energy while the machine is powered off or sleeping.
> 
> Tested using an Armada 370 based board (LS421DE) equipped with a Marvell
> 88E1518 PHY.
> 
> Signed-off-by: Daniel González Cabanelas <dgcbueu@...il.com>
> ---
> Changes in v2:
>   - Patch reworked with the new phylink_speed_(up|down) functions
>     provided by Russel King. This should avoid the kernel OOPs issue when
>     used with a switch or a PHY on a SFP module.

Applied to net-next.