netdev - Re: [MPTCP] [PATCH net-next v2 3/4] mptcp: move crypto test to KUNIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.23.453.2006261425220.66996@redsall-mobl2.amr.corp.intel.com>
Date:   Fri, 26 Jun 2020 14:25:48 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Paolo Abeni <pabeni@...hat.com>
cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, mptcp@...ts.01.org,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [MPTCP] [PATCH net-next v2 3/4] mptcp: move crypto test to
 KUNIT

On Fri, 26 Jun 2020, Paolo Abeni wrote:

> currently MPTCP uses a custom hook to executed unit tests at
> boot time. Let's use the KUNIT framework instead.
> Additionally move the relevant code to a separate file and
> export the function needed by the test when self-tests
> are build as a module.
>
> Co-developed-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> Signed-off-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
> net/mptcp/Kconfig       | 20 ++++++++----
> net/mptcp/Makefile      |  3 ++
> net/mptcp/crypto.c      | 63 ++----------------------------------
> net/mptcp/crypto_test.c | 72 +++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 91 insertions(+), 67 deletions(-)
> create mode 100644 net/mptcp/crypto_test.c

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel