netdev - Re: [PATCH net] enetc: Fix tx rings bitmap iteration range, irq handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200626.150305.1841670809009065570.davem@davemloft.net>
Date:   Fri, 26 Jun 2020 15:03:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     claudiu.manoil@....com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] enetc: Fix tx rings bitmap iteration range, irq
 handling

From: Claudiu Manoil <claudiu.manoil@....com>
Date: Fri, 26 Jun 2020 19:17:29 +0300

> The rings bitmap of an interrupt vector encodes
> which of the device's rings were assigned to that
> interrupt vector.
> Hence the iteration range of the tx rings bitmap
> (for_each_set_bit()) should be the total number of
> Tx rings of that netdevice instead of the number of
> rings assigned to the interrupt vector.
> Since there are 2 cores, and one interrupt vector for
> each core, the number of rings asigned to an interrupt
> vector is half the number of available rings.
> The impact of this error is that the upper half of the
> tx rings could still generate interrupts during napi
> polling.
> 
> Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers")
> Signed-off-by: Claudiu Manoil <claudiu.manoil@....com>

Applied and queued up for -stable, thank you.