netdev - Re: [PATCH net-next v2 0/4] mptcp: refactor token container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200626.162231.1590461076613614486.davem@davemloft.net>
Date:   Fri, 26 Jun 2020 16:22:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, kuba@...nel.org, mptcp@...ts.01.org,
        edumazet@...gle.com
Subject: Re: [PATCH net-next v2 0/4] mptcp: refactor token container

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri, 26 Jun 2020 19:29:58 +0200

> Currently the msk sockets are stored in a single radix tree, protected by a
> global spin_lock. This series moves to an hash table, allocated at boot time,
> with per bucker spin_lock - alike inet_hashtables, but using a different key:
> the token itself.
> 
> The above improves scalability, as write operations will have a far later chance
> to compete for lock acquisition, allows lockless lookup, and will allow
> easier msk traversing - e.g. for diag interface implementation's sake.
> 
> This also introduces trivial, related, kunit tests and move the existing in
> kernel's one to kunit.
> 
> v1 -> v2:
>  - fixed a few extra and sparse warns

Series applied, thanks Paolo.