netdev - Re: [PATCH v1] rds: If one path needs re-connection, check all and re-connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200626.163100.603726050168307590.davem@davemloft.net>
Date:   Fri, 26 Jun 2020 16:31:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rao.shoaib@...cle.com
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        ka-cheong.poon@...cle.com, david.edmondson@...cle.com
Subject: Re: [PATCH v1] rds: If one path needs re-connection, check all and
 re-connect

From: rao.shoaib@...cle.com
Date: Fri, 26 Jun 2020 11:34:38 -0700

> +/* Check connectivity of all paths
> + */
> +void rds_check_all_paths(struct rds_connection *conn)
> +{
> +	int i = 0;
> +
> +	do {
> +		rds_conn_path_connect_if_down(&conn->c_path[i]);
> +	} while (++i < conn->c_npaths);
> +}

Please code this loop in a more canonial way:

	int i;

	for (i = 0; i < conn->c_npaths, i++)
		rds_conn_path_connect_if_down(&conn->c_path[i]);

Thank you.