netdev - [PATCH net-next] Fix unchecked dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200626085435.6627-1-justin.iurman@uliege.be>
Date:   Fri, 26 Jun 2020 10:54:35 +0200
From:   Justin Iurman <justin.iurman@...ege.be>
To:     dan.carpenter@...cle.com
Cc:     kbuild@...ts.01.org, justin.iurman@...ege.be,
        netdev@...r.kernel.org, lkp@...el.com, kbuild-all@...ts.01.org,
        davem@...emloft.net
Subject: [PATCH net-next] Fix unchecked dereference

If rhashtable_remove_fast returns an error, a rollback is applied. In
that case, an unchecked dereference has been fixed.

Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
Signed-off-by: Justin Iurman <justin.iurman@...ege.be>
---
 net/ipv6/ioam6.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/ioam6.c b/net/ipv6/ioam6.c
index e414e915bf1e..f1347940245e 100644
--- a/net/ipv6/ioam6.c
+++ b/net/ipv6/ioam6.c
@@ -161,7 +161,8 @@ static int ioam6_genl_delns(struct sk_buff *skb, struct genl_info *info)
 	err = rhashtable_remove_fast(&nsdata->namespaces, &ns->head,
 				     rht_ns_params);
 	if (err) {
-		ns->schema->ns = ns;
+		if (ns->schema)
+			ns->schema->ns = ns;
 		goto out_unlock;
 	}
 
@@ -355,7 +356,8 @@ static int ioam6_genl_delsc(struct sk_buff *skb, struct genl_info *info)
 	err = rhashtable_remove_fast(&nsdata->schemas, &sc->head,
 				     rht_sc_params);
 	if (err) {
-		sc->ns->schema = sc;
+		if (sc->ns)
+			sc->ns->schema = sc;
 		goto out_unlock;
 	}
 
-- 
2.17.1