netdev - Re: [PATCH bpf-next v2 2/4] libbpf: add support for BPF_CGROUP_INET_SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZxasCcvrT2fQ9szXe6TjFwPGiv9vsGOjPJdKcozn70XQ@mail.gmail.com>
Date:   Fri, 26 Jun 2020 17:59:41 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH bpf-next v2 2/4] libbpf: add support for BPF_CGROUP_INET_SOCK_RELEASE

On Fri, Jun 26, 2020 at 4:52 PM Stanislav Fomichev <sdf@...gle.com> wrote:
>
> On Fri, Jun 26, 2020 at 3:08 PM Andrii Nakryiko
> <andrii.nakryiko@...il.com> wrote:
> >
> > On Fri, Jun 26, 2020 at 10:22 AM Stanislav Fomichev <sdf@...gle.com> wrote:
> > >
> > > Add auto-detection for the cgroup/sock_release programs.
> > >
> > > Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
> > > ---
> >
> > Left a bunch of comments on v1 of this series, oops.
> No worries, there is not much changed since then, thanks for the review!
>
> > But where is the cover letter? Did I miss it?
> I didn't feel like it deserves a cover letter. The main patch is
> small, most of the changes are in libbpf/selftests and I mostly split
> them to make it easier for you to push to github (is it still a
> requirement or I shouldn't worry about it anymore?).

It's not a requirement, sync script is pretty smart about all that, so
no need to do it specifically for the sync purposes. Still a good idea
to have selftests separately, IMO.

As for the cover letter, unless it's some trivial independent fixes,
cover letter ties everything together and is a good place to track
"what changed between versions". So I'd recommend adding it anyways.