netdev - Re: [net-next 01/13] igc: Add initial EEE support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200627.172854.1616926333918264313.davem@davemloft.net>
Date:   Sat, 27 Jun 2020 17:28:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     sasha.neftin@...el.com, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com, andre.guedes@...el.com,
        aaron.f.brown@...el.com
Subject: Re: [net-next 01/13] igc: Add initial EEE support

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 26 Jun 2020 18:54:19 -0700

> +static int igc_ethtool_get_eee(struct net_device *netdev,
> +			       struct ethtool_eee *edata)
> +{
> +	struct igc_adapter *adapter = netdev_priv(netdev);
> +	struct igc_hw *hw = &adapter->hw;
> +	u32 eeer;
> +
> +	if (hw->dev_spec._base.eee_enable)
> +		edata->advertised =
> +			mmd_eee_adv_to_ethtool_adv_t(adapter->eee_advert);
> +
> +	*edata = adapter->eee;
> +	edata->supported = SUPPORTED_Autoneg;
> +	netdev_info(netdev,
> +		    "Supported EEE link modes: 100baseT/Full, 1000baseT/Full, 2500baseT/Full\n");

I don't think you want to print a kernel log message every time someone
executes an ethtool query like this.

Please remove this.