netdev - Re: [PATCH net-next v3 0/5] hinic: add some ethtool ops support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <073f94da-c36c-e737-3b41-7671a942eb7b@huawei.com>
Date:   Sun, 28 Jun 2020 08:58:26 +0800
From:   "luobin (L)" <luobin9@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <luoxianjun@...wei.com>, <yin.yinshi@...wei.com>,
        <cloud.wangxiaoyun@...wei.com>, <chiqijun@...wei.com>
Subject: Re: [PATCH net-next v3 0/5] hinic: add some ethtool ops support

On 2020/6/28 8:52, David Miller wrote:
> From: Luo bin <luobin9@...wei.com>
> Date: Sat, 27 Jun 2020 14:52:37 +0800
> 
>> patch #1: support to set and get pause params with
>>           "ethtool -A/a" cmd
>> patch #2: support to set and get irq coalesce params with
>>           "ethtool -C/c" cmd
>> patch #3: support to do self test with "ethtool -t" cmd
>> patch #4: support to identify physical device with "ethtool -p" cmd
>> patch #5: support to get eeprom information with "ethtool -m" cmd
> 
> In general,  I want you to decrease the amount of log messages.
> 
> You should only use them when the device or the kernel does something
> unexpected which should be notifier to the user.
> 
> Kernel log messages are not for informating the user of limitations
> of what they can perform with "ethtool".
> 
> For example, when setting pause paramenters, you complain in the logs
> if the autonet setting is different.
> 
> This is completely inappropriate.
> 
> Then in patch #2 you have these crazy macros that print out state
> changes with netdev_info().  That is also inappropriate.  The user
> gets a success status, and they can query the settings later if
> they like as well.
> 
> Please stop abusing kernel log messaging, it isn't a framework for
> giving more detailed ethtool command result statuses.
> 
> Thank you.
> .
> 
Okay, I'll remove these normal kernel logs. Thank you for your review.