netdev - Re: [PATCH] rtlwifi/*/dm.c: Use const in swing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1593400347.12786.8.camel@realtek.com>
Date:   Mon, 29 Jun 2020 03:12:56 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     "joe@...ches.com" <joe@...ches.com>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations

On Sun, 2020-06-28 at 19:51 -0700, joe@...ches.com wrote:
> On 2020-06-28 19:09, Pkshih wrote:
> > On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote:
> > 
> > Use 'rtlwifi:' as subject title prefix is enough, likes
> >   rtlwifi: Use const in swing_table declarations
> 
> We disagree.
> 
> I like knowing what content is changed via patch subject lines
> as there are 3 rtlwifi drivers being changed by this one patch.

If 3 drivers are needed to be listed, I'd use below subject

"rtlwifi: Use const in rtl8188ee/rtl8723be/rtl8821ae swing_table declarations"

> 
> But your choice, you can change it if you choose.
> 
> >> Reduce data usage about 1KB by using const.
> []
> > Please remove below type casting: 
> > 
> > @@ -1872,10 +1872,10 @@ static void 
> > rtl8821ae_get_delta_swing_table(struct
> > ieee80211_hw *hw,
> >                 *up_b = rtl8821ae_delta_swing_table_idx_5gb_p[2];
> >                 *down_b = rtl8821ae_delta_swing_table_idx_5gb_n[2];
> >         } else {
> > -           *up_a = (u8 *)rtl8818e_delta_swing_table_idx_24gb_p;
> > -           *down_a = (u8 *)rtl8818e_delta_swing_table_idx_24gb_n;
> > -           *up_b = (u8 *)rtl8818e_delta_swing_table_idx_24gb_p;
> > -           *down_b = (u8 *)rtl8818e_delta_swing_table_idx_24gb_n;
> > +               *up_a = rtl8818e_delta_swing_table_idx_24gb_p;
> > +               *down_a = rtl8818e_delta_swing_table_idx_24gb_n;
> > +               *up_b = rtl8818e_delta_swing_table_idx_24gb_p;
> > +               *down_b = rtl8818e_delta_swing_table_idx_24gb_n;
> 
> The compiler is quiet about this so I believe this to be
> an unrelated change and whitespace correction.

I know compiler doesn't warn this, but it looks wired to cast 'const u8 *'
to 'u8 *' to 'const u8 *'.


> 
> Of course you could modify it if you choose.
> 
> btw: There's an unnecessary return at the 2nd instance
>       of this cast removal too.

It seems like to copy from rtl8812ae_get_delta_swing_table(), so
I can remove it by another patch.

> 
> cheers, Joe
> 
> ------Please consider the environment before printing this e-mail.