netdev - Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200629202147.GL5499@sirena.org.uk>
Date:   Mon, 29 Jun 2020 21:21:47 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        davem@...emloft.net, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com, Fred Oh <fred.oh@...ux.intel.com>
Subject: Re: [net-next v4 10/12] ASoC: SOF: Introduce descriptors for SOF
 client

On Sat, May 23, 2020 at 08:23:51AM +0200, Greg KH wrote:

> Then fix that problem there.  The audio card should not be being created
> as a platform device, as that is not what it is.  And even if it was,
> the probe should not complete, it should clean up after itself and error
> out.

To be clear ASoC sound cards are physical devices which exist in the
real world.

> That's not a driver core issue, sounds like a subsystem error handling
> issue that needs to be resolved.

It's not a subsystem issue, it's an issue with the half baked support
for enumerating modern audio hardware on ACPI systems.  Unfortunately
we have to enumerate hardware based on having data tables instantiated
via DMI information for the system which doesn't work well with a
generic kernel like Linux, on Windows they're per-machine custom
drivers.  There is some effort at putting some of the data into ACPI
tables on newer systems which is helping a lot but it's partial.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)