netdev - Re: [PATCH net-next v13 2/3] xen networking: add basic XDP support for xen-netfront

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOJe8K35osOCKOhrLCKGKns7Hu0M+EAP6TUvwbpsgS_B7Vi2jQ@mail.gmail.com>
Date:   Mon, 29 Jun 2020 13:14:57 +0300
From:   Denis Kirjanov <kda@...ux-powerpc.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, brouer@...hat.com, jgross@...e.com,
        wei.liu@...nel.org, paul@....org, ilias.apalodimas@...aro.org
Subject: Re: [PATCH net-next v13 2/3] xen networking: add basic XDP support
 for xen-netfront

On 6/26/20, Jakub Kicinski <kuba@...nel.org> wrote:
> On Fri, 26 Jun 2020 14:40:38 +0300 Denis Kirjanov wrote:
>> The patch adds a basic XDP processing to xen-netfront driver.
>>
>> We ran an XDP program for an RX response received from netback
>> driver. Also we request xen-netback to adjust data offset for
>> bpf_xdp_adjust_head() header space for custom headers.
>>
>> synchronization between frontend and backend parts is done
>> by using xenbus state switching:
>> Reconfiguring -> Reconfigured- > Connected
>>
>> UDP packets drop rate using xdp program is around 310 kpps
>> using ./pktgen_sample04_many_flows.sh and 160 kpps without the patch.
>>
>> Signed-off-by: Denis Kirjanov <kda@...ux-powerpc.org>
>
> Still here:
>
> drivers/net/xen-netfront.c: In function xennet_xdp_xmit_one:
> drivers/net/xen-netfront.c:581:31: warning: variable tx set but not used
> [-Wunused-but-set-variable]
>   581 |  struct xen_netif_tx_request *tx;
>       |                               ^~
Hi Jakub,

Ohh... going to send a fixed version.

Thanks.