netdev - Re: [PATCH net] llc: make sure applications use ARPHRD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 28 Jun 2020 21:42:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] llc: make sure applications use ARPHRD_ETHER

From: Eric Dumazet <edumazet@...gle.com>
Date: Sat, 27 Jun 2020 13:31:50 -0700

> syzbot was to trigger a bug by tricking AF_LLC with
> non sensible addr->sllc_arphrd
> 
> It seems clear LLC requires an Ethernet device.
> 
> Back in commit abf9d537fea2 ("llc: add support for SO_BINDTODEVICE")
> Octavian Purdila added possibility for application to use a zero
> value for sllc_arphrd, convert it to ARPHRD_ETHER to not cause
> regressions on existing applications.
 ...
> Fixes: abf9d537fea2 ("llc: add support for SO_BINDTODEVICE")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks Eric.