netdev - Re: [PATCH] net: qrtr: free flow in __qrtr_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5754bde02e4026ace2ef4ca9fb8ae47@codeaurora.org>
Date:   Mon, 29 Jun 2020 19:50:06 +0800
From:   cjhuang@...eaurora.org
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        ath11k@...ts.infradead.org
Subject: Re: [PATCH] net: qrtr: free flow in __qrtr_node_release

On 2020-06-24 11:26, David Miller wrote:
> From: Carl Huang <cjhuang@...eaurora.org>
> Date: Tue, 23 Jun 2020 11:22:03 +0800
> 
>> @@ -168,6 +168,7 @@ static void __qrtr_node_release(struct kref *kref)
>>  	struct radix_tree_iter iter;
>>  	unsigned long flags;
>>  	void __rcu **slot;
>> +	struct qrtr_tx_flow *flow;
> 
> Please retain the reverse christmas tree ordering of local variables 
> here.

OK. Will send V2 for it.

> 
> Thanks.