netdev - RE: Re: [iproute2-next] action police: make 'mtu' could be set independently in police action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <VE1PR04MB6496EA762B0749A7CC92FBCE926E0@VE1PR04MB6496.eurprd04.prod.outlook.com>
Date:   Mon, 29 Jun 2020 00:51:30 +0000
From:   Po Liu <po.liu@....com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "dsahern@...il.com" <dsahern@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "vlad@...lov.dev" <vlad@...lov.dev>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Alexandru Marginean <alexandru.marginean@....com>
Subject: RE:  Re: [iproute2-next] action police: make 'mtu' could be set
 independently in police action

Hi Stephen,


> -----Original Message-----
> From: Stephen Hemminger <stephen@...workplumber.org>
> Sent: 2020年6月29日 4:16
> To: Po Liu <po.liu@....com>
> Cc: dsahern@...il.com; linux-kernel@...r.kernel.org;
> netdev@...r.kernel.org; davem@...emloft.net; jhs@...atatu.com;
> vlad@...lov.dev; Claudiu Manoil <claudiu.manoil@....com>; Vladimir
> Oltean <vladimir.oltean@....com>; Alexandru Marginean
> <alexandru.marginean@....com>
> Subject: Re: [iproute2-next] action police: make 'mtu' could be set
> independently in police action
> 
> On Sun, 28 Jun 2020 09:46:02 +0800
> Po Liu <po.liu@....com> wrote:
> 
> > Current police action must set 'rate' and 'burst'. 'mtu' parameter set
> > the max frame size and could be set alone without 'rate' and 'burst'
> > in some situation. Offloading to hardware for example, 'mtu' could
> > limit the flow max frame size.
> >
> > Signed-off-by: Po Liu <po.liu@....com>
> > ---
> >  tc/m_police.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tc/m_police.c b/tc/m_police.c index a5bc20c0..89497f67
> > 100644
> > --- a/tc/m_police.c
> > +++ b/tc/m_police.c
> > @@ -161,8 +161,8 @@ action_ctrl_ok:
> >               return -1;
> >
> >       /* Must at least do late binding, use TB or ewma policing */
> > -     if (!rate64 && !avrate && !p.index) {
> > -             fprintf(stderr, "\"rate\" or \"avrate\" MUST be specified.\n");
> > +     if (!rate64 && !avrate && !p.index && !mtu) {
> > +             fprintf(stderr, "\"rate\" or \"avrate\" or \"mtu\"MUST
> > + be specified.\n");
> 
> Missing blank.
> Your message will come out as:
> "rate" or "avrate" or "mtu"MUST be specified.

Get it. Will correct. 
Thanks!

> 
> 
> The quotes aren't adding to the readability, why not just remove them
> instead.

Will remove all quotes.

Br,
Po Liu